[BEAM-1251] Modernize Python 2 code to get ready for Python 3 #5842
Conversation
|
It seems that Lint and Docs failed. You can run them via |
|
Note that this change conflicts with #5373, which fixes some of the same issues. |
|
@charlesccychen It is not so much that these PRs are conflicting. It is more like they are trying to make many of the same changes. We have been trying for a while to make this repo Python 3 compatible by running futurize so let's not slow things down by waiting. Full speed ahead on all efforts. |
|
@superbobry @holdenk Could I please get your review on these changes? |
|
LGTM. Can you rebase the change? |
cclauss
force-pushed
the
print_is_a_function_in_python3
branch
2 times, most recently
from
b826a83
to
f674206
Compare
Signed-off-by: cclauss <cclauss@bluewin.ch>
cclauss
force-pushed
the
print_is_a_function_in_python3
branch
from
f674206
to
38a317a
Compare
|
Rebased |
|
Thanks @cclauss! |
| @@ -29,12 +29,18 @@ | |||
| 'sudo apt-get install python-beautifulsoup4'. | |||
|
|
|||
| """ | |||
| from __future__ import print_function | |||
There was a problem hiding this comment.
The website source code is currently being migrated from https://github.com/apache/beam-site, but is not yet ready. Website changes in apache/beam will be overwritten on next merge. Please contribute changes at apache/beam-site according to the website contribution guide. You can track migration progress via [BEAM-4493].
Do you know if this change was also made in the apache/beam-site repository? If not, it will need to be migrated.
Signed-off-by: cclauss cclauss@bluewin.ch
Please add a meaningful description for your change here
Fix Python 3 syntax errors and undefined names.
@aaltay I am confused why it is necessary to keep making these PRs. I thought that we had put in place automated testing on Python 3 that would use flake8 to flag syntax errors and undefined names so that these anachronisms would not be checked into the codebase.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)