[BEAM-4774] Nexmark SQL Postcommits #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apilloud
requested review from
aromanenko-dev,
echauchot and
lgajowy
as code owners
|
R: @echauchot |
|
LGTM |
|
Hit flaps in |
|
run java precommit |
|
|
|
run java precommit |
|
@apilloud yes there was some side-effect flakiness introduced in ElasticsearchIOTest lately. I need to take a look |
echauchot
approved these changes
Jul 16, 2018
There was a problem hiding this comment.
Seems good. I cannot be 100% sure because we can not longer (disabled) run postCommits using phrase triggering. We'll see with next commit to master. Besides, with this PR you'll add numberOfQueriesImplementedInSQL x 3Runners x 2Modes (except spark streaming) tables in nexmark big query dataset.
|
@apilloud can you squash the 2 commits into one and rename it with the ticket number? |
|
I've squashed and renamed the commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Nexmark SQL jobs to the post commits.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)