Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4787] Ignore generated vendor files in python container build #5950

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

angoenka
Copy link
Contributor

Ignore generated files for python container build

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@angoenka
Copy link
Contributor Author

R: @aaltay @tweise

@tweise
Copy link
Contributor

tweise commented Jul 13, 2018

There are a few more vendor files that should me moved out of sight:

	runners/gcp/gcemd/vendor/
	runners/gcp/gcsproxy/vendor/
	sdks/java/container/vendor/
	sdks/python/container/vendor/

I think the existing entry sdks/go/**/vendor/**/* can be augmented to capture the other sdk container builds also?

@angoenka
Copy link
Contributor Author

angoenka commented Jul 13, 2018

Sure, I will add the following to the list. I hope that if we accidentally ignore valid file then we will catch it soon in the build.

sdks/**/vendor/**/*
runners/**/vendor/**/*

@tweise tweise merged commit 6230523 into apache:master Jul 14, 2018
@lukecwik
Copy link
Member

Thanks for fixing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants