Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-4453] Add convenience methods for pojo and javabean schema registration. #6114

Merged
merged 2 commits into from Aug 1, 2018
Merged

[BEAM-4453] Add convenience methods for pojo and javabean schema registration. #6114

merged 2 commits into from Aug 1, 2018

Conversation

reuvenlax
Copy link
Contributor

No description provided.

@reuvenlax
Copy link
Contributor Author

R:@apilloud

apilloud
apilloud approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaRegistry.java Outdated
@@ -67,8 +68,40 @@
private final Map<TypeDescriptor, SchemaEntry> entries = Maps.newHashMap();
private final ArrayDeque<SchemaProvider> providers;

class PerTypeRegisteredProvider implements SchemaProvider {
private Map<TypeDescriptor, SchemaProvider> providers = Maps.newHashMap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaRegistry.java Outdated
}
}

private PerTypeRegisteredProvider perTypeRegisteredProviders = new PerTypeRegisteredProvider();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaRegistry.java Outdated
@@ -67,8 +68,40 @@
private final Map<TypeDescriptor, SchemaEntry> entries = Maps.newHashMap();
private final ArrayDeque<SchemaProvider> providers;

class PerTypeRegisteredProvider implements SchemaProvider {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@reuvenlax
Copy link
Contributor Author

Run Java PreCommit

@reuvenlax reuvenlax merged commit ddef7de into apache:master Aug 1, 2018
@reuvenlax reuvenlax deleted the convenience_pojo_bean_provider branch December 9, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apilloud apilloud apilloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reuvenlax @apilloud