Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5125] Increase timeout on PortableExecutionTest to reduce flakiness. #6204

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Ardagan
Copy link
Contributor

@Ardagan Ardagan commented Aug 10, 2018

Test is failing often in pre-commit tests and post-commit tests. This looks like failing due to timeout. Setting less strict timeout might resolve flakiness.

BEAM-5125


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@Ardagan
Copy link
Contributor Author

Ardagan commented Aug 10, 2018

R: @lukecwik

@Ardagan
Copy link
Contributor Author

Ardagan commented Aug 10, 2018

run java precommit

@Ardagan Ardagan changed the title [BEAM-5125] Increase timeout on test to reduce flakiness. [BEAM-5125] Increase timeout on PortableExecutionTest to reduce flakiness. Aug 10, 2018
@Ardagan
Copy link
Contributor Author

Ardagan commented Aug 10, 2018

@pabloem

@pabloem
Copy link
Member

pabloem commented Aug 13, 2018

run java precommit

@pabloem
Copy link
Member

pabloem commented Aug 13, 2018

LGTM.

@pabloem pabloem merged commit 5bbc602 into apache:master Aug 13, 2018
@Ardagan Ardagan deleted the PortableExecutionTest branch November 30, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants