Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-5193] Correct typos in KuduIOTest testWrite #6263

Merged
merged 1 commit into from Aug 22, 2018
Merged

[BEAM-5193] Correct typos in KuduIOTest testWrite #6263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/java/io/kudu/src/test/java/org/apache/beam/sdk/io/kudu/KuduIOTest.java
View file
Open in desktop
Expand Up @@ -125,9 +125,9 @@ public void testRead() throws KuduException {
}

/**
* Test the write path using a {@link FakeWriter} and verifying the expected log statements are
* Test the write path using a {@link FakeWriter} and verifies the expected log statements are
* written. This test ensures that the {@link KuduIO} correctly respects parallelism by
* deserializes writers and that each writer is opening and closing Kudu sessions.
* deserializing writers and that each writer is opening and closing Kudu sessions.
*/
@Test
public void testWrite() throws Exception {
Expand All @@ -144,14 +144,14 @@ public void testWrite() throws Exception {
.withKuduService(mockWriteService));
writePipeline.run().waitUntilFinish();

for (int i = 1; i <= targetParallelism + 1; i++) {
for (int i = 1; i <= targetParallelism; i++) {
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
}
// verify all entries written
for (int n = 0; n > numberRecords; n++) {
for (int n = 0; n < numberRecords; n++) {
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
}
Expand Down