[BEAM-5308] Correct/cleanup DockerOnMac code in DockerJobBundleFactory #6335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug which led to bind exceptions due to always using a fixed port range on MacOS. We only have to use a fixed port range for the SDK harness processes when we're already running in a container, e.g. local testing with the Job Server running in Docker. A fixed port range is necessary due to missing host networking on MacOS which otherwise doesn't allow the SDK harness containers to connect to the container of the execution engine.
|
@mxm thanks for working on it! Does this patch also address the Docker container not terminating after the job finished? AFAIK that only happens when running on the Flink cluster, not in embedded mode. |
tweise
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug which led to bind exceptions due to always using a fixed port
range on MacOS. We only have to use a fixed port range for the SDK harness
processes when we're already running in a container, e.g. local testing with the
Job Server running in Docker.
A fixed port range is necessary due to missing host networking on MacOS which
otherwise doesn't allow the SDK harness containers to connect to the container
of the execution engine.
CC @tweise
Post-Commit Tests Status (on master branch)