-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-5364] Check if validation is disabled when validating BigtableSource #6413
Conversation
@chamikaramj Please take a look. |
Failures seems to be related: https://builds.apache.org/job/beam_PreCommit_Java_Commit/1316/console |
Not sure if the failure is related to the change in the PR: 16:48:00 FAILURE: Build failed with an exception. |
I found the error. |
Added a missing period in a comment. |
Thanks. Please fixup commits into a single commit. |
Squash comments on merge at the end? |
Squash commits on merge at the end? |
I can, but Beam prefers merge commits :) : https://beam.apache.org/contribute/committer-guide/ |
Add a missing period.
…to fix_validate
sigh.... I messed up on rebase :( |
Check if validation is disabled when validating BigtableSource