Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5364] Check if validation is disabled when validating BigtableSource #6413

Closed
wants to merge 4 commits into from

Conversation

kevinsi4508
Copy link
Contributor

Check if validation is disabled when validating BigtableSource

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@kevinsi4508
Copy link
Contributor Author

@chamikaramj Please take a look.

@chamikaramj
Copy link
Contributor

Failures seems to be related: https://builds.apache.org/job/beam_PreCommit_Java_Commit/1316/console

@kevinsi4508
Copy link
Contributor Author

Not sure if the failure is related to the change in the PR:

16:48:00 FAILURE: Build failed with an exception.
16:48:00
16:48:00 * What went wrong:
16:48:00 Execution failed for task ':beam-sdks-java-io-google-cloud-platform:checkstyleTest'.
16:48:00 > Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/io/google-cloud-platform/build/reports/checkstyle/test.html
16:48:00 Checkstyle files with violations: 1
16:48:00 Checkstyle violations by severity: [error:1]
16:48:00

@kevinsi4508
Copy link
Contributor Author

I found the error.

@kevinsi4508
Copy link
Contributor Author

Added a missing period in a comment.

@chamikaramj
Copy link
Contributor

Thanks. Please fixup commits into a single commit.

@kevinsi4508
Copy link
Contributor Author

Squash comments on merge at the end?

@kevinsi4508
Copy link
Contributor Author

Squash commits on merge at the end?

@chamikaramj
Copy link
Contributor

I can, but Beam prefers merge commits :) : https://beam.apache.org/contribute/committer-guide/

@kevinsi4508
Copy link
Contributor Author

sigh.... I messed up on rebase :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants