[BEAM-5444] Revert Flink PostCommit to parallelism 1 #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 8f94a03, the parallelism defaults to the number of available CPU cores in local setups. Since this breaks PostCommit, we default to parallelism 1 for those tests.
|
Run Java PostCommit |
|
Run Python PreCommit |
|
Run Flink ValidatesRunner |
|
I realized that we can just run the Flink validates runner test to make sure this fixes the issue, rather than speculating. If it passes, LGTM. |
|
Thanks for keeping an eye on the build!
PostCommit includes Flink Validates Runner, no? Though much quicker to run only the Flink parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 8f94a03, the parallelism defaults to the number of available CPU cores in local setups. Since this breaks PostCommit, we default to parallelism 1 for those tests.
CC @lostluck
Post-Commit Tests Status (on master branch)