[BEAM-1251] Upgrade pylint version for py27-lint3 #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
commented
Sep 25, 2018
| @@ -191,6 +191,7 @@ def expand(self, pcoll): | |||
|
|
|||
| class SafeFastPrimitivesCoder(coders.Coder): | |||
| """This class add an quote/unquote step to escape special characters.""" | |||
| # pylint: disable=deprecated-urllib-function | |||
There was a problem hiding this comment.
This code has already been changed in #6451
RobbeSneyders
commented
Sep 25, 2018
| @@ -55,6 +55,7 @@ def instance_to_type(o): | |||
| if o is None: | |||
| return type(None) | |||
| elif t not in typehints.DISALLOWED_PRIMITIVE_TYPES: | |||
| # pylint: disable=deprecated-types-field | |||
There was a problem hiding this comment.
This is needed for old-style Python 2 classes.
RobbeSneyders
added a commit
to RobbeSneyders/beam
that referenced
this pull request
Sep 25, 2018
tvalentyn
reviewed
Sep 25, 2018
| @@ -81,6 +81,7 @@ def __init__(self, side_inputs): | |||
| self._transform_to_side_inputs[side.pvalue.producer].append(side) | |||
|
|
|||
| def __repr__(self): | |||
| # pylint: disable=dict-values-not-iterating | |||
There was a problem hiding this comment.
Would s/if self._views.values()/if self._views/ remove the lint warning?
There was a problem hiding this comment.
You're right. I've removed the values() call.
tvalentyn
approved these changes
Sep 25, 2018
splovyt
pushed a commit
to splovyt/beam
that referenced
this pull request
Oct 1, 2018
* Upgrade pylint for py27-lint3 test to 1.9.3
splovyt
pushed a commit
to splovyt/beam
that referenced
this pull request
Oct 2, 2018
* Upgrade pylint for py27-lint3 test to 1.9.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tvalentyn @Fematich @aaltay
Post-Commit Tests Status (on master branch)