[BEAM-4524] Use sha256 instead of insecure md5 for artifact checksums. #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid base64, as there are many dialects (which we were not choosing consistently, the primary one using characters like '/' unsuitable for filenames). Lowercase hex is also more standard for cryptographic sums and easier to verify.
|
MD5 is a checksum used by GCS, Azure storage and others. It's convenient that they match. The checksum is not used for security decisions. Is there a JIRA describing the rationale for changing it? |
robertwb
changed the title
|
MD5 is broken, and the Apache foundation has explicitly asked us to move
away from it (for release signing at the very least). More importantly, if
we ever support caching/sharing of pipeline artifacts, this becomes a
security risk.
…On Sat, Oct 6, 2018 at 12:46 AM Henning Rohde ***@***.***> wrote:
MD5 is a checksum used by GCS, Azure storage and others. It's convenient
that they match. The checksum is not used for security decisions. Is there
a JIRA describing the rationale for changing it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6583 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdqgUCdcUDsr_XH0FP1QK-JrKiRNheWks5uh-E2gaJpZM4XKfXS>
.
|
|
R: @boyuanzz |
boyuanzz
approved these changes
Nov 14, 2018
|
Thanks! Rerunning a couple of tests before merging as it's been a while. |
|
Run PreCommit |
|
Run JavaPortabilityApi PreCommit |
|
Run Python Flink ValidatesRunner |
|
Run Python PreCommit |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoid base64, as there are many dialects (which we were not
choosing consistently, the primary one using characters like '/'
unsuitable for filenames). Lowercase hex is also more standard for
cryptographic sums and easier to verify.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)