Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1081] Annotations custom message support and classes tests. #6670

Merged
merged 1 commit into from Oct 17, 2018

Conversation

jglezt
Copy link
Contributor

@jglezt jglezt commented Oct 12, 2018

Added support for custom messages using the arg "custom_message".
The annotation decorator already supports tagging classes, I only added a few tests to check it out.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

Copy link
Member

@pabloem pabloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Javier. Thanks for your contribution. There seems to have been a file that wasnt merged properly. Can you fix that? You can run tox from within sdks/python to run all of the unit tests, and lint checks

sdks/python/apache_beam/utils/annotations_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/utils/annotations_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/utils/annotations_test.py Outdated Show resolved Hide resolved
@jglezt
Copy link
Contributor Author

jglezt commented Oct 12, 2018

Hi Pablo!
I resolved the merge problems.
Waiting for the Jenkins build.

@aaltay
Copy link
Member

aaltay commented Oct 12, 2018

@jglezt it looks like there are test issues, could you look at those?

@jglezt
Copy link
Contributor Author

jglezt commented Oct 15, 2018

Test issues fixed.

@pabloem pabloem merged commit 8142643 into apache:master Oct 17, 2018
@pabloem
Copy link
Member

pabloem commented Oct 17, 2018

Very cool. Thanks for the contribution again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants