Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1251] Add a link to Python 3 Conversion Quick Start Guide to the list of ongoing efforts on Beam site. #6679

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

tvalentyn
Copy link
Contributor


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@tvalentyn
Copy link
Contributor Author

Hey @swegner, am I using a correct way to change the Beam-site? Thanks.

@swegner
Copy link
Contributor

swegner commented Oct 12, 2018

Yup!

If you pop open the "All checks have passed" bar, you'll see a link to the "Website_Stage_GCS" job results, which contains a link to your staged changes for review: http://apache-beam-website-pull-requests.storage.googleapis.com/6679/index.html

(I'm brainstorming a way to make that link more prominent on GitHub; let me know if you have ideas)

@tvalentyn
Copy link
Contributor Author

@swegner we can explore a possibility to add a link to staged website to the PR template. Also https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/ says it may be possible to have multiple pull request templates. Maybe we could have a separate template for site changes, but then unclear what template should have a PR that touches both SDK and site.

@tvalentyn
Copy link
Contributor Author

r: @aaltay

@aaltay aaltay merged commit ba3ef6e into apache:master Oct 16, 2018
@swegner
Copy link
Contributor

swegner commented Oct 16, 2018

@tvalentyn I had looked into the possibility of multiple templates. However it appears that the workflow for selecting a pull request requires using a special pull request URL with query parameters (docs). I don't like the idea of requiring contributors to mess with URLs to open a PR.

@tvalentyn tvalentyn deleted the patch-25 branch October 23, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants