[BEAM-5098] Fix withoutDefaults and withFanout clearing side inputs #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution and this looks good to me. I have added you as a contributor to the Apache Beam JIRA project and assigned BEAM-5098. This will allow you to assign issues to yourself in the future. If you haven't yet found our contribution guide, it is available here https://beam.apache.org/contribute/. Would you like to open up a follow-up PR which adds a regression test for withFanout as well? |
|
R: @lukecwik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
withFanoutorwithFanoutonCombine.Globallywould clear side input. This was due to those two functions using a constructor that did not accept side inputs. I have removed the offending constructor and rewritten the two functions to use the correct constructor.I have also added a regression test in a separate commit. If it's too much for such a simple change, you can just merge commit with the fix.
Post-Commit Tests Status (on master branch)