[BEAM-6010] Deprecate KafkaIO withTimestampFn(). #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+R: @jbonofre, @aromanenko-dev |
aromanenko-dev
approved these changes
Nov 7, 2018
aromanenko-dev
changed the title
|
Thanks for merging this. |
|
Yes, I'm agree, but before final removing this I'd wonder if Beam has any internal rules about that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimestampPolicyFactory.withTimestampFn()was never meant to be public. It was a mistake on my part not to make package private when I first added it. It was included only to existing legacy API inKafkaIO.Read(also deprecated). This policy is too simplistic (sets watermark to most recent record timestamp) and almost always wrong. There is a better alternative.