[BEAM-2687] Correctly handle read-before-write semantics for user state. #7102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwb
force-pushed
the
nested-state
branch
from
608f137
to
6624cad
Compare
ryan-williams
approved these changes
Nov 27, 2018
sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
Outdated
Show resolved
Hide resolved
| yield buffer | ||
|
|
||
| def is_buffered_correctly(actual): | ||
| # Issues pickling closure of self on jenkins. |
There was a problem hiding this comment.
some more detail about this might be useful, unless it would be obvious to someone more familiar with the code
| self = FnApiRunnerTest('__init__') | ||
| # assert sorted(sum((list(b) for b in actual), [])) == elements | ||
| # assert max(len(list(buffer)) for buffer in actual) == buffer_size | ||
| self.assertEqual(sorted(sum((list(b) for b in actual), [])), elements) |
There was a problem hiding this comment.
for my education, what might actual be here? is it nondeterministic based on timer firings?
Co-Authored-By: robertwb <robertwb@gmail.com>
Co-Authored-By: robertwb <robertwb@gmail.com>
|
Thanks, PTAL. |
|
looks good, thanks! |
ajamato
pushed a commit
to ajamato/beam
that referenced
this pull request
Nov 28, 2018
ajamato
pushed a commit
to ajamato/beam
that referenced
this pull request
Nov 30, 2018
ajamato
pushed a commit
to ajamato/beam
that referenced
this pull request
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)