[BEAM-6139] Adding support for BQ GEOGRAPHY data type #7144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java PreCommit |
|
Because the Java SDK performs avro exports, this feature is blocked for Java until BQ Avro exports support WKT. I'd like to go forward only with Python for now. |
|
@chamikaramj PTAL. Michael Entin has given approval for this code path, so I think we can move forward, while we wait for BQ to support WKT on avro exports. |
chamikaramj
reviewed
Dec 4, 2018
|
Also fixed support statement. |
|
I believe this is ready to merge (after squashing) |
|
LGTM. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to sources for BQ connectors in Java and Python to support GEOGRAPHY data type.