[BEAM-6182] Disable conscrypt by default #7203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @chamikaramj (We may need to cherry pick this to the release branch.) |
swegner
approved these changes
Dec 5, 2018
| "Dataflow runner uses conscrypt by default for SSL. To disable this feature, " | ||
| + "pass pipeline option --experiments={}", | ||
| "Dataflow runner is using conscrypt SSL. To disable this feature, " | ||
| + "remove the pipeline option --experiments={}", | ||
| experimentName); | ||
| Security.insertProviderAt(new OpenSSLProvider(), 1); | ||
| } else { | ||
| LOG.info( |
There was a problem hiding this comment.
I would demote this to debug log. Since the Beam default is now consistent with Java default, it seems like it will be noise for most users.
There was a problem hiding this comment.
I would like to keep it as an info since this is a change in behavior for Dataflow runner.
...orker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkerHarnessHelper.java
Show resolved
Hide resolved
...low-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/ExperimentContext.java
Show resolved
Hide resolved
aaltay
changed the title
|
Thank you @swegner. Addressed your questions. Will merge this after tests pass. |
aaltay
added a commit
to aaltay/beam
that referenced
this pull request
Dec 5, 2018
* Disable conscrypt by default
chamikaramj
added a commit
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the default because conscrypt is continuing to cause stability issues. This change only affects Dataflow runner.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)