Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6196] Redirect from nexmark page's older location #7225

Merged
merged 1 commit into from Dec 7, 2018

Conversation

udim
Copy link
Member

@udim udim commented Dec 7, 2018

Currently searching for "beam nexmark" on Google returns this link 404 link as the first result:
https://beam.apache.org/documentation/sdks/java/nexmark/


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

Currently searching for "beam nexmark" on Google returns this link 404 link as the first result:
https://beam.apache.org/documentation/sdks/java/nexmark/
@udim
Copy link
Member Author

udim commented Dec 7, 2018

Redirecting is a bit broken (I hope) on the website staging thing, but you can see that it works (adds testing to the path):
https://apache-beam-website-pull-requests.storage.googleapis.com/7225/documentation/sdks/java/nexmark/index.html

@udim
Copy link
Member Author

udim commented Dec 7, 2018

R: @swegner

@udim
Copy link
Member Author

udim commented Dec 7, 2018

swegner is OOO.
R: @Ardagan

@Ardagan
Copy link
Contributor

Ardagan commented Dec 7, 2018

Good catch.

@Ardagan
Copy link
Contributor

Ardagan commented Dec 7, 2018

@pabloem (committer)

@pabloem
Copy link
Member

pabloem commented Dec 7, 2018

I tried to verify this, and I'm notsure if im doing it right. It may be because the staging only stages html files?

Neither one of these seem to work:
http://apache-beam-website-pull-requests.storage.googleapis.com/7225/documentation/sdks/java/nexmark/index.html
http://apache-beam-website-pull-requests.storage.googleapis.com/7225/documentation/sdks/java/nexmark/

@pabloem
Copy link
Member

pabloem commented Dec 7, 2018

Discussed this offline. Merging.

@pabloem pabloem changed the title Redirect from nexmark page's older location [BEAM-6196] Redirect from nexmark page's older location Dec 7, 2018
@pabloem pabloem merged commit a226343 into apache:master Dec 7, 2018
@udim udim deleted the patch-2 branch December 7, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants