[BEAM-4453] Stop subclassing user POJOs. #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenlax
force-pushed
the
remove_pojo_subclass
branch
from
b8e34a8
to
6280255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were subclassing user POJO objects in order to create them from a Beam Row. This can cause unexpected behavior: e.g. many equals() implementations check that the class is the same, and and will fail if the rhs is a subclass. In this PR we stop doing this, and instead simply generate the code to create the POJO directly.
As a bonus, this should be a small performance boost, as we no longer use reflection to creat e the object.