[BEAM-6287] pyarrow is not supported on Windows Python 2 #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @udim |
ihji
force-pushed
the
dont_install_pyarrow_windows_py2
branch
3 times, most recently
from
1558fea
to
8c7b82b
Compare
ihji
force-pushed
the
dont_install_pyarrow_windows_py2
branch
from
8c7b82b
to
be7549c
Compare
|
confirm that installation and test work fine on Windows Python 2 👍 |
|
run python precommit |
|
R: @chamikaramj |
udim
reviewed
Jan 2, 2019
| @@ -41,7 +41,14 @@ | |||
| from apache_beam.transforms import CombineGlobally | |||
| from apache_beam.transforms.combiners import Count | |||
|
|
|||
| if not (platform.system() == 'Windows' and sys.version_info[0] == 2): | |||
There was a problem hiding this comment.
Next time please use the more common format to handle missing modules used elsewhere in the codebase:
try:
import pyarrow as pa
except ImportError:
pa = None@unittest.skipIf(pa is None, "...")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering out pyarrow dependency when the platform is Windows and Python version is 2. There's no pyarrow package for the given platform and version.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)