[BEAM-1251] Unskip passing Python 3 tests #7446
Conversation
RobbeSneyders
force-pushed
the
remove-skip
branch
from
a293d82
to
8675291
Compare
|
Some tests still fail on Jenkins while succeeding locally. I'll look into this. |
|
@tvalentyn @markflyhigh |
|
Asked on https://issues.apache.org/jira/browse/INFRA-17335 to upgrade the interpreter. Sounds like this may be a limitation we may want to call out. Do we understand the nature of the failures on 3.5.2? |
|
retest this please |
|
(just to take another look on the failure we see). |
|
These tests pass on 3.3. I suggest we skip the passing tests only if Python interpreter version is less than 3.5.3, then we will keep the tests for 3.6, and devs running 3.5.3 or higher on their workstations will still exercise the tests. |
RobbeSneyders
force-pushed
the
remove-skip
branch
from
8675291
to
6c6b72a
Compare
|
Ok, thank you. Sounds good. |
|
No, instead of warnings I think we will have to set python_requires to >= 3.5.3 for Python 3 versions. |
| @@ -38,9 +38,12 @@ class _TestClass(object): | |||
|
|
|||
|
|
|||
| class NativeTypeCompatibilityTest(unittest.TestCase): | |||
| @unittest.skipIf(sys.version_info[0] == 3 and | |||
|
|
|||
| @unittest.skipIf(sys.version_info[0] == 3 and sys.version_info[1] < 6 and | |||
There was a problem hiding this comment.
sys.version_info[1] < 3?
There was a problem hiding this comment.
Changed to sys.hexversion for easy checking.
RobbeSneyders
force-pushed
the
remove-skip
branch
from
5bb92ac
to
4c09c44
Compare
|
@aaltay @charlesccychen to help with the merge, thank you! |
This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here: https://s.apache.org/beam-python-3.
This PR removes the skip condition for some tests which were indirectly fixed for Python 3.
Post-Commit Tests Status (on master branch)