[BEAM-6351] Divide separate job for "smoke" load test suites #7497
Conversation
lgajowy
force-pushed
the
BEAM-6351_OOMErrorFix
branch
from
f88e9f4
to
ae79538
Compare
|
Run seed job |
lgajowy
force-pushed
the
BEAM-6351_OOMErrorFix
branch
from
ae79538
to
348c38b
Compare
|
Run seed job |
|
Run Java Load Tests Smoke |
lgajowy
force-pushed
the
BEAM-6351_OOMErrorFix
branch
from
348c38b
to
f39d1de
Compare
|
Run seed job |
|
Run Java Load Tests Smoke |
1 similar comment
|
Run Java Load Tests Smoke |
|
Run GroupByKey Small Java Load Test Dataflow |
| ] | ||
| ], | ||
| [ | ||
| title : 'GroupByKey load test Dataflow', |
There was a problem hiding this comment.
I added a tiny variant of a Dataflow test too in order to quickly detect if nothing gets broken on dataflow too (dependencies, worker problems etc). In the future, other runners should have their variants too.
@apilloud Do you think it might be useful to add such smoke suite to post-commit jobs?
There was a problem hiding this comment.
I think adding smoke tests for other runners is probably useful. Most have local runners so the test should be fairly quick. Dataflow doesn't have this option and takes a few minutes to start up, so tests less than a few minutes will be mostly startup time.
There was a problem hiding this comment.
Good idea - I added suites for Spark and Flink.
lgajowy
changed the title
There was a problem hiding this comment.
LGTM. Thanks for working on tests.
I looked at the Jenkins console logs for the dataflow job and it looks like the SDK log messages didn't make it there. (I'm looking for log messages about uploading to GCS and the Dataflow job ID.) Would be good to get those working so we have some ability to debug when these fail.
|
Run seed job |
|
Run Java Load Tests Smoke |
|
@apilloud thanks a lot. You're right - it's a trivial task to add smoke suites for other runners too, so I added configs for Spark and Flink here. Together with them, the job takes about 10 minutes so I think it is acceptable. Could you take a look again? I also created an issue for the dataflow SDK logs you mentioned: https://issues.apache.org/jira/browse/BEAM-6448 After this gets merged I'm going to add a PostCommit (not only phrase triggered) job if there's no objections (JIRA for this: https://issues.apache.org/jira/browse/BEAM-6449) |
|
@apilloud I know you accepted this, but I added Spark and Flink smoke tests. Could you take a glimpse? |
|
Sorry, I missed your last comment. LGTM. |
|
Thanks! Merging. |
Added a separate job that will run "smoke" load test suite to verify if everything's going well. More tests can be added to the smoke suite in the future. The idea is to have one "smoke" job and separate load test jobs.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)