Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-6444] Fix equality comparison to be against method invocation, not method object #7522

Merged
merged 1 commit into from Jan 16, 2019
Merged

[BEAM-6444] Fix equality comparison to be against method invocation, not method object #7522

merged 1 commit into from Jan 16, 2019

Conversation

takidau
Copy link
Contributor

@takidau takidau commented Jan 16, 2019

Fixes broken equality comparison introduced in ffec471.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status		 Build Status --- --- ---

@takidau
Copy link
Contributor Author

takidau commented Jan 16, 2019

@aaltay

@aaltay
Copy link
Member

aaltay commented Jan 16, 2019

Flink test failed with a known issue (now fixed: #7533) Rest of the tests are passing, merging.

@aaltay aaltay merged commit 18dcde2 into apache:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaltay aaltay aaltay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takidau @aaltay