[BEAM-6440] Ensure state backend key is set for timer deduplication #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During working on the Savepoint restore test a problem showed up for portable pipelines not having the state backend key set before cleaning up the pending timers map. This moves the cleanup to before firing the timer when the key is ensured to be set.
|
Run Python Flink ValidatesRunner |
|
Python ValidatesRunner tests currently broken: https://issues.apache.org/jira/browse/BEAM-6469 |
|
Merging this with #7362 which surfaced the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During working on the Savepoint restore test a problem showed up for portable
pipelines not having the state backend key set before cleaning up the pending
timers map.
This moves the cleanup to before firing the timer when the key is ensured to be
set.
CC @tweise
Post-Commit Tests Status (on master branch)