[BEAM-6207] Added option to publish synthetic data to Kafka topic. #7612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kkucharc , could you look at it? Thanks! |
mwalenia
force-pushed
the
BEAM-6207-add-kafka-to-synth-pubsub
branch
2 times, most recently
from
db59671
to
a87a869
Compare
|
One test failure is in Task :beam-runners-google-cloud-dataflow-java-legacy-worker:test, unrelated to these changes. |
kkucharc
requested changes
Jan 24, 2019
...ing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPubSubPublisher.java
Outdated
Show resolved
Hide resolved
...ing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPubSubPublisher.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
mwalenia
force-pushed
the
BEAM-6207-add-kafka-to-synth-pubsub
branch
from
a87a869
to
b2b0b28
Compare
lgajowy
reviewed
Jan 28, 2019
...ing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPubSubPublisher.java
Outdated
Show resolved
Hide resolved
...ing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPubSubPublisher.java
Outdated
Show resolved
Hide resolved
...ing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPubSubPublisher.java
Outdated
Show resolved
Hide resolved
...ing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPubSubPublisher.java
Outdated
Show resolved
Hide resolved
lgajowy
requested changes
Jan 30, 2019
...a/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java
Outdated
Show resolved
Hide resolved
...a/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java
Show resolved
Hide resolved
...a/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java
Outdated
Show resolved
Hide resolved
...a/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java
Outdated
Show resolved
Hide resolved
...a/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java
Show resolved
Hide resolved
mwalenia
force-pushed
the
BEAM-6207-add-kafka-to-synth-pubsub
branch
from
ffaac57
to
07bc1c6
Compare
added 2 commits
January 30, 2019 15:04
SyntheticDataPubSubPublisher now accepts --kafkaBootstrapServerAddress option which switches it to Kafka publishing mode instead of Google PubSub mode. Key-Value pairs are published as strings.
SyntheticDataPubSubPublisher now accepts --kafkaBootstrapServerAddress option which switches it to Kafka publishing mode instead of Google PubSub mode. Key-Value pairs are published as strings.
mwalenia
force-pushed
the
BEAM-6207-add-kafka-to-synth-pubsub
branch
from
07bc1c6
to
7e1f775
Compare
|
LGTM, thanks! Merging. |
lgajowy
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntheticDataPubSubPublisher now accepts --kafkaBootstrapServerAddress option
which switches it to Kafka publishing mode instead of Google PubSub mode.
Key-Value pairs are published as strings.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)