-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-6154] Update google-apitools to 0.5.26 and fix gcsio in python 3 #7617
Conversation
+R: @tvalentyn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @markflyhigh !
Run Dataflow Python ValidatesRunner |
Run Python Dataflow ValidatesRunner |
2 similar comments
Run Python Dataflow ValidatesRunner |
Run Python Dataflow ValidatesRunner |
retest this please |
Run Python Dataflow ValidatesRunner |
d0c7322
to
d58c287
Compare
Run Python Dataflow ValidatesRunner |
retest this please |
R: @aaltay |
google-apitools 0.5.26 contains a critical python 3 fix that help to unblock DataflowRunner in Python 3. The problem is described in https://issues.apache.org/jira/browse/BEAM-6154. This PR contains fix to the problem as well as upgrade google-apitools.
Note: this fix touches
base_image_requirements.txt
which is used to build Python sdk harness container image.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username
) to look at it.Post-Commit Tests Status (on master branch)