[BEAM-4776] make AutoValues for MetricResults, MetricQueryResults #7621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-williams
force-pushed
the
autovalues
branch
from
84a25c0
to
36057d5
Compare
tweise
approved these changes
Jan 28, 2019
ryan-williams
commented
Jan 28, 2019
| /** Return the metric results for the counters that matched the filter. */ | ||
| Iterable<MetricResult<Long>> getCounters(); | ||
| public abstract class MetricQueryResults { | ||
| /** Return the metric results for the getCounters that matched the filter. */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and remove duplicated implementations from
directanddirect/portablerunnersThis is an early bit of cleanup that came out of work I'm doing to plumb metrics over the job API (cf. BEAM-4776). In later work I re-use these same concrete
@AutoValueclasses a third time.R: @mxm, @ajamato
CC: @youngoli
Post-Commit Tests Status (on master branch)