Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6305] Update Cassandra java driver to version 3.6.0 #7658

Merged

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Jan 29, 2019

This also unifies versions for all modules that use Cassandra driver, e.g. hadoop-input-format and hadoop-format
R: @aromanenko-dev

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just added a minor note and, please, rebase this since it has conflicts because of previous Cassandra-related merge.

@@ -24,14 +24,14 @@ enableJavaPerformanceTesting()
description = "Apache Beam :: SDKs :: Java :: IO :: Cassandra"
ext.summary = "IO to read and write with Apache Cassandra database"

def cassandra_version = "3.5.0"
def cassandra_version = "3.6.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this definition could be deleted since it's not used anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixing it, thanks.

@iemejia iemejia force-pushed the BEAM-6305-cassandra-driver-update branch from 5e5f654 to c30eefa Compare January 29, 2019 14:59
@iemejia
Copy link
Member Author

iemejia commented Jan 29, 2019

Rebased, it should be good soon.

@aromanenko-dev
Copy link
Contributor

LGTM

@aromanenko-dev aromanenko-dev merged commit efb83e6 into apache:master Jan 29, 2019
@iemejia iemejia deleted the BEAM-6305-cassandra-driver-update branch January 29, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants