[BEAM-6512] Fixes flake in GrpcDataServiceTest #7784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertwb could you take a look at this? I chatted a bit with Thomas Groh who wrote the original test, and he said you'd be the most knowledgeable about this. I'm a little concerned that explicitly waiting for exactly three calls to onNext could be cheating - e.g. is it possible for it to be called >3 times and we should call that a test failure? FYI - here's a gradle scan with some more detailed logging from the original flake |
|
Closing in favor of #7794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronizes based on outbound elements rather than inbound, to ensure that we don't make an assertion before the elements have been received in the clients.
Post-Commit Tests Status (on master branch)