[BEAM-5612] Add py3 cython tox environment #7802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
commented
Feb 11, 2019
| # If we want to add other platforms in the future, it should be: | ||
| # `platform = linux2|darwin|...` | ||
| # See https://docs.python.org/2/library/sys.html#sys.platform for platform codes | ||
| platform = linux |
There was a problem hiding this comment.
https://docs.python.org/3.5/library/sys.html#sys.platform
Changed in version 3.3: On Linux, sys.platform doesn’t contain the major version anymore. It is always 'linux', instead of 'linux2' or 'linux3'. Since older Python versions include the version number, it is recommended to always use the startswith idiom presented above
|
Retest this please |
RobbeSneyders
force-pushed
the
py3-cython
branch
3 times, most recently
from
287e810
to
7af11dd
Compare
|
RobbeSneyders
force-pushed
the
py3-cython
branch
from
7af11dd
to
f55441a
Compare
|
Failure was due to a typo. |
tvalentyn
approved these changes
Feb 12, 2019
|
Thank you! |
aaltay
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here: https://s.apache.org/beam-python-3.
This PR adds a py3-cython test suite to tox.
Post-Commit Tests Status (on master branch)