[BEAM-6324] Remove withWhere from CassandraIO (superceded by withQuery) #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iemejia
commented
Mar 27, 2019
| @@ -305,26 +285,6 @@ public void testReadWithQuery() throws Exception { | |||
| pipeline.run(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testReadWithValueProvider() throws Exception { | |||
There was a problem hiding this comment.
This one was removed because the functionality is already covered by delegation from the different with methods e.g. withTable(String) -> withTable(ValueProvider).
And we win some performance because of one less test that does not validate anything new.
iemejia
commented
Mar 27, 2019
| @@ -106,12 +105,6 @@ public void testWriteThenRead() { | |||
| runRead(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testWriteThenReadWithWhere() { | |||
There was a problem hiding this comment.
This one was removed because the functionality is already tested in the unit tests via withQuery, and because ITs it could be easily subsumed by testWriteThenReadWithWhere
|
This is reasonable. We've synced offline, and the short answer is that allowing the user to compose their queries is much more reasonable. Thanks Ismael. |
|
LGTM. |
|
Thanks Pablo for the eager review. I will take care of the ticket now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @echauchot @pabloem