[BEAM-4610] Add SSL support for RedisIO #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iemejia
requested changes
Mar 28, 2019
| @@ -79,6 +79,16 @@ | |||
| * | |||
| * }</pre> | |||
| * | |||
| * <p>It's also possible to enable Redis SSL connection with the corresponding methods: | |||
There was a problem hiding this comment.
remove the comment (let it like it was)
| @@ -99,9 +105,18 @@ public RedisConnectionConfiguration withTimeout(int timeout) { | |||
| return builder().setTimeout(timeout).build(); | |||
| } | |||
|
|
|||
| /** | |||
| * Enable SSL connection to Redis server. | |||
There was a problem hiding this comment.
nit: remove the @return part and inline like the other methods
| @@ -199,6 +209,10 @@ public Read withBatchSize(int batchSize) { | |||
| return builder().setBatchSize(batchSize).build(); | |||
| } | |||
|
|
|||
| public Read enableSSL() { | |||
There was a problem hiding this comment.
Remove, users wanting to do this can do it via the ConnectionConfiguration object.
| } | ||
|
|
||
| @Test | ||
| public void testReadBuildsWithSslCorrectly() { |
There was a problem hiding this comment.
remove, we may consider a future PR to add ConnectionConfigurationTest but so far we have avoided to test AutoValue's configurations.
|
Thanks @iemejia for the code review! FYI, the modification has been done and it is ready to get merged. |
iemejia
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Here is the PR for SSL connection support to RedisIO. The idea is to just add a SSL flag to allow the Redis client to open a SSL connection with its default SSL parameters. Thanks in advance for the review. (R: @iemejia )
Regards,
Guobao
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.