[BEAM-6934] Fixing timer firing timing issue #8252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaltay
reviewed
Apr 9, 2019
| | beam.ParDo(BagStateClearingStatefulDoFn()) | ||
| | beam.ParDo(self.record_dofn())) | ||
|
|
||
| self.assertEqual( |
There was a problem hiding this comment.
Is it possible to check whether emit_values fired or not at all?
There was a problem hiding this comment.
I've added a check for that. Thanks!
aaltay
approved these changes
Apr 9, 2019
ibzib
pushed a commit
to ibzib/beam
that referenced
this pull request
Apr 22, 2019
* Fixing timer firing timing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is odd about this problem is that:
100to fire when the watermark advances to 100 - but instead, it fires together with the timer set to1000when the watermark advances to infinity.On the other hand, if we set
advance_watermark_to(101), the test behaves properly without any need for modifications.BUT, what's even more odd is that when doing the actual check in trigger.py as to whether the timer should be fired, we do check for
<=. Strange.:https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/trigger.py#L1273
Nonetheless, this change does fix the new test (which was previously failing) - and I believe it does correct the behavior. So. Yes.
I'll keep hunting for bugs.
r: @aaltay
cc: @tweise