Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-6669] Set Dataflow KMS key name (Python) #8297

Merged
merged 1 commit into from May 7, 2019

Conversation

udim
Copy link
Member

@udim udim commented Apr 12, 2019

Use the official Environment.service_kms_key_name proto field to pass
--dataflow_kms_key to the runner.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Use the official Environment.service_kms_key_name proto field to pass
--dataflow_kms_key to the runner.
@udim
Copy link
Member Author

udim commented Apr 12, 2019

run python postcommit

@udim
Copy link
Member Author

udim commented Apr 12, 2019

R: @lukecwik

@udim
Copy link
Member Author

udim commented Apr 15, 2019

retrying postcommits - ran out of quota:


Workflow failed. Causes: Project apache-beam-testing has insufficient quota(s) to execute this workflow with 1 instances in region us-central1. Quota summary (required/available): 1/7235 instances, 1/0 CPUs, 250/115509 disk GB, 0/4046 SSD disk GB, 1/246 instance groups, 1/247 managed instance groups, 1/189 instance templates, 1/490 in-use IP addresses.

@udim
Copy link
Member Author

udim commented Apr 15, 2019

run python postcommit

1 similar comment
@lukecwik
Copy link
Member

run python postcommit

@lukecwik
Copy link
Member

I fixed the "multimap" serialization issue that was impacting Python ITs

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests are green

@udim
Copy link
Member Author

udim commented Apr 19, 2019

I'm Investigating Python precommit failures. https://issues.apache.org/jira/browse/BEAM-7111

@udim
Copy link
Member Author

udim commented Apr 19, 2019

Correction: postcommits

@udim
Copy link
Member Author

udim commented May 1, 2019

run python postcommit

1 similar comment
@udim
Copy link
Member Author

udim commented May 2, 2019

run python postcommit

@aaltay
Copy link
Member

aaltay commented May 7, 2019

Can we merge this?

@lukecwik
Copy link
Member

lukecwik commented May 7, 2019

Yes, I was waiting for the tests to be green which was the primary reason for the delay.

@lukecwik lukecwik merged commit a6a6b8e into apache:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants