New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-6669] Set Dataflow KMS key name (Python) #8297
Conversation
Use the official Environment.service_kms_key_name proto field to pass --dataflow_kms_key to the runner.
run python postcommit |
R: @lukecwik |
retrying postcommits - ran out of quota:
|
run python postcommit |
1 similar comment
run python postcommit |
I fixed the "multimap" serialization issue that was impacting Python ITs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests are green
I'm Investigating Python precommit failures. https://issues.apache.org/jira/browse/BEAM-7111 |
Correction: postcommits |
run python postcommit |
1 similar comment
run python postcommit |
Can we merge this? |
Yes, I was waiting for the tests to be green which was the primary reason for the delay. |
Use the official Environment.service_kms_key_name proto field to pass
--dataflow_kms_key to the runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.