[BEAM-7157] Allow creation of BinaryCombineFn from lambdas. #8409
Conversation
|
R: @youngoli |
robertwb
force-pushed
the
bin-combine-lambda
branch
from
586d277
to
f616142
Compare
robertwb
force-pushed
the
bin-combine-lambda
branch
from
f616142
to
8403313
Compare
|
Run Java PreCommit |
|
I keep getting timeouts in org.apache.beam.runners.dataflow.worker.fn.BeamFnControlServiceTest.testClientConnecting which are irrelevant to this change. |
| @FunctionalInterface | ||
| public interface SerializableBiFunction<FirstInputT, SecondInputT, OutputT> | ||
| extends BiFunction<FirstInputT, SecondInputT, OutputT>, Serializable { | ||
| // This class is empty, but required for creating serializable lambda expressions. |
There was a problem hiding this comment.
| // This class is empty, but required for creating serializable lambda expressions. | |
| // This interface is empty, but required for creating serializable lambda expressions. |
| }; | ||
| } | ||
|
|
||
| public static BinaryCombineFn<Long> foo() { |
There was a problem hiding this comment.
Are these two functions (foo and bar) supposed to be here? Looks like testing code that was left behind.
There was a problem hiding this comment.
Oh, yes, I was validating what inference could and could not accept. It's now in the test file but I forgot to delete it here. Thanks.
|
Run Java PreCommit |
|
testClientConnecting is still failing. I see some precommits are passing. I can't tell if it's flaky or if the fix is in master and isn't included in this PR. I think you should try to get the Java Precommit passing if you can, but the change itself looks good so I'm approving it. |
|
Run Java PreCommit |
|
Thanks for the review. Looks like this precommit is now failing more often than not, and spot checking reveals this test to be the culprit. This change is clearly unrelated so I'm going to go ahead and merge. |
This came up in a recent user thread.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.