Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7162] Add ValueProvider to CassandraIO Write #8413

Closed
wants to merge 1 commit into from
Closed

[BEAM-7162] Add ValueProvider to CassandraIO Write #8413

wants to merge 1 commit into from

Conversation

mathieublanchard
Copy link
Contributor

@mathieublanchard mathieublanchard commented Apr 26, 2019

Currently, the ValueProvider type is only available for the Read.builder() attributes and we need it for some write operations.


Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@mathieublanchard
Copy link
Contributor Author

@echauchot @iemejia

@iemejia iemejia self-requested a review April 26, 2019 15:46
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge manually just to correct one really minor thing.

@iemejia iemejia changed the title [BEAM-7162] Cassandra ValueProvider / Write Operations [BEAM-7162] Add ValueProvider to CassandraIO Write Apr 26, 2019
iemejia added a commit that referenced this pull request Apr 26, 2019
@iemejia
Copy link
Member

iemejia commented Apr 26, 2019

Merged manually, thanks @mblmat !

@iemejia iemejia closed this Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants