Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7179] Correct file extension #8434

Merged
merged 1 commit into from May 1, 2019
Merged

Conversation

AaronLeeIV
Copy link
Contributor

DATAFLOW_GRAPH_FILE_NAME (String DATAFLOW_GRAPH_FILE_NAME = "dataflow_graph.pb") 's file extension is set to .pb however it is indeed a .json.

The content is generated as

options
  .getStager()
  .stageToFile(
      DataflowPipelineTranslator.jobToString(newJob).getBytes(UTF_8),
      DATAFLOW_GRAPH_FILE_NAME);

see also DataflowPipelineTranslator

While the actual proto String PIPELINE_FILE_NAME = "pipeline.pb"
is generated as

options.getStager().stageToFile(serializedProtoPipeline, PIPELINE_FILE_NAME);

@lukecwik Can you take a look.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

DATAFLOW_GRAPH_FILE_NAME 's extension is set to .pb however it is indeed a .json. The content is generated as

```
DataflowPipelineTranslator.jobToString(newJob).getBytes(UTF_8)
```
@lukecwik
Copy link
Member

Could you reference a JIRA (file one if it doesn't exist) related to this change?

@AaronLeeIV AaronLeeIV changed the title Correct file extension [BEAM-7179] Correct file extension Apr 30, 2019
@AaronLeeIV
Copy link
Contributor Author

Indeed, filed issue and updated the subject.

@AaronLeeIV
Copy link
Contributor Author

retest this please

2 similar comments
@AaronLeeIV
Copy link
Contributor Author

retest this please

@AaronLeeIV
Copy link
Contributor Author

retest this please

@lukecwik
Copy link
Member

Run Java PreCommit

2 similar comments
@lukecwik
Copy link
Member

Run Java PreCommit

@lukecwik
Copy link
Member

lukecwik commented May 1, 2019

Run Java PreCommit

@lukecwik lukecwik merged commit 77294ed into apache:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants