Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7260] UTF8 coder is breaking dataflow tests #8545

Merged
merged 1 commit into from May 10, 2019

Conversation

ihji
Copy link
Contributor

@ihji ihji commented May 10, 2019

StringUtf8Coder is now ModelCoder in JavaSDK. We need to add it to
WELL_KNOWN_CODER_TYPES for dataflow worker harness as well.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

StringUtf8Coder is now ModelCoder in JavaSDK. We need to add it to
WELL_KNOWN_CODER_TYPES for dataflow worker harness as well.
@ihji
Copy link
Contributor Author

ihji commented May 10, 2019

R: @robertwb

@angoenka
Copy link
Contributor

I am optimistically going to merge this change unbroken master.
@robertwb Please review it and if needed we can revert it this PR.

@angoenka angoenka merged commit da4bb49 into apache:master May 10, 2019
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

angoenka added a commit to angoenka/beam that referenced this pull request May 10, 2019
This reverts commit da4bb49, reversing
changes made to 01e9878.
@ihji ihji deleted the BEAM-7260 branch July 1, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants