[BEAM-3606] Remove guava-testlib from sdks/java/core main dependency set #8759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the usage of an EqualsTester with our own implementation. The eventual goal is to stop shading guava as a default and then eventually to stop shading modules by default.
Ardagan
approved these changes
Jun 4, 2019
youngoli
reviewed
Jun 4, 2019
| for (int i = 0; i < equalityGroups.size(); ++i) { | ||
| List<T> current = equalityGroups.get(i); | ||
| for (int j = 0; j < current.size(); ++j) { | ||
| for (int k = 0; k < current.size(); ++k) { |
There was a problem hiding this comment.
Could you do int k = j instead here to avoid duplicate comparisons?
There was a problem hiding this comment.
Since equals is implemented within the class a.equals(b) is not the same thing as b.equals(a) if a and b are two different classes, we also test a.equals(a) for posterity.
There was a problem hiding this comment.
Ah, I didn't consider that case. Ok that makes sense now.
| current.get(k)); | ||
| } | ||
| } | ||
| for (int j = 0; j < equalityGroups.size(); ++j) { |
There was a problem hiding this comment.
Here too, it seems like you could just do int j = i + 1 and avoid duplicate comparisons (and self comparisons)
There was a problem hiding this comment.
Same reasoning about the equals as above, we ensure that they are not equals both ways as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the usage of an EqualsTester with our own implementation.
The eventual goal is to stop shading guava as a default and then eventually to stop shading modules by default.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.