New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-7530] allow read None bytes #8817
Conversation
Run Python PostCommit |
R: @tvalentyn |
@@ -928,7 +928,7 @@ def __iter__(self): | |||
# return base64 encoded bytes as byte type on python 3 | |||
# which matches the behavior of Beam Java SDK | |||
for i in range(len(row.f)): | |||
if self.schema.fields[i].type == 'BYTES': | |||
if self.schema.fields[i].type == 'BYTES' and row.f[i].v: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Could you please add to one of BQ IT tests a test scenario that reads and writes a row of None values for BQ datatypes that allow value to be None ?
Thank you!
We can merge this to make sure that 2.14 picks up the fix, but please add the missing test scenarios in a follow-up change. Thank you. |
@pabloem could you please help with the merge? |
Thanks @tvalentyn. I will add a test for this scenario next week |
ping @pabloem :-) |
@aaltay or @chamikaramj - Could you please help with the merge? Thanks! |
bugfix when reading None values from bigquery
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.