[BEAM-7531] Remove and disallow KMS key setting #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for default buckets.
3 tasks
lukecwik
approved these changes
Jun 14, 2019
|
Thanks @lukecwik ! |
udim
added a commit
to udim/beam
that referenced
this pull request
Jun 18, 2019
In apache#8830, the reliance on an auto-created bucket with default key was removed. - Introduces a new --tempRootKms flag, for use with tests that need a --tempRoot with default key (currently only select GCP tests). - Simplifies GcsKmsKeyIT's KMS key verification (to notNull), since the bucket default key and --dataflowKmsKey do not match.
udim
added a commit
to udim/beam
that referenced
this pull request
Jun 18, 2019
In apache#8830, the reliance on an auto-created bucket with default key was removed. - Introduces a new --tempRootKms flag, for use with tests that need a --tempRoot with default key (currently only select GCP tests). - Simplifies GcsKmsKeyIT's KMS key verification (to notNull), since the bucket default key and --dataflowKmsKey do not match.
udim
added a commit
to udim/beam
that referenced
this pull request
Jun 18, 2019
In apache#8830, the reliance on an auto-created bucket with default key was removed. - Introduces a new --tempRootKms flag, for use with tests that need a --tempRoot with default key (currently only select GCP tests). - Simplifies GcsKmsKeyIT's KMS key verification (to notNull), since the bucket default key and --dataflowKmsKey do not match.
3 tasks
Hannah-Jiang
pushed a commit
to Hannah-Jiang/beam
that referenced
this pull request
Jun 26, 2019
In apache#8830, the reliance on an auto-created bucket with default key was removed. - Introduces a new --tempRootKms flag, for use with tests that need a --tempRoot with default key (currently only select GCP tests). - Simplifies GcsKmsKeyIT's KMS key verification (to notNull), since the bucket default key and --dataflowKmsKey do not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for default buckets.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.