Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-7221] Spark portable runner: support timers #8841

Merged
merged 1 commit into from Jun 13, 2019
Merged

[BEAM-7221] Spark portable runner: support timers #8841

merged 1 commit into from Jun 13, 2019

Conversation

ibzib
Copy link
Contributor

@ibzib ibzib commented Jun 12, 2019

Shouldn't be anything surprising here.

R: @mxm @angoenka

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ibzib
Copy link
Contributor Author

ibzib commented Jun 12, 2019

Run Python Spark ValidatesRunner

@ibzib
Copy link
Contributor Author

ibzib commented Jun 12, 2019

Run Java Spark PortableValidatesRunner Batch

@iemejia iemejia requested a review from mxm June 12, 2019 23:14
@mxm
Copy link
Contributor

mxm commented Jun 13, 2019

Run Java Flink PortableValidatesRunner Batch

mxm
mxm approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me.

iemejia
iemejia approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great!

@iemejia iemejia changed the title [BEAM-7221] portable Spark: timers [BEAM-7221] Spark portable runner: support timers Jun 13, 2019
@iemejia iemejia merged commit 66b090d into apache:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iemejia iemejia iemejia approved these changes

@mxm mxm mxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ibzib @mxm @iemejia