Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7601] fixed typo #8910

Merged
merged 1 commit into from Jun 21, 2019
Merged

[BEAM-7601] fixed typo #8910

merged 1 commit into from Jun 21, 2019

Conversation

@brucearctor
Copy link

brucearctor commented Jun 20, 2019

In https://beam.apache.org/community/in-person/, under Meetups:

Actual: occassionally

Expected: occasionally


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@brucearctor

This comment has been minimized.

Copy link
Author

brucearctor commented Jun 20, 2019

@brucearctor

This comment has been minimized.

Copy link
Author

brucearctor commented Jun 20, 2019

R: @mxm

@mxm
mxm approved these changes Jun 20, 2019
Copy link
Contributor

mxm left a comment

Nice! LGTM if tests pass.

website/src/community/in-person.md Outdated Show resolved Hide resolved
@brucearctor

This comment has been minimized.

Copy link
Author

brucearctor commented Jun 20, 2019

@mxm - fixed rest of page to make it consistent (single spaces abound)

@mxm

This comment has been minimized.

Copy link
Contributor

mxm commented Jun 20, 2019

Thank you @brucearctor. Will squash and merge after the tests pass.

@brucearctor

This comment has been minimized.

Copy link
Author

brucearctor commented Jun 20, 2019

Run Website PreCommit

@mxm

This comment has been minimized.

Copy link
Contributor

mxm commented Jun 20, 2019

Retest this please

@mxm

This comment has been minimized.

Copy link
Contributor

mxm commented Jun 20, 2019

Github web hook issue have been resolved.

@mxm

This comment has been minimized.

Copy link
Contributor

mxm commented Jun 20, 2019

Could you squash the three commits into a single commit, then force push? If I use the "Squash and merge" feature of Github, it will change the author to my name, which would be a shame :)

@mxm mxm force-pushed the brucearctor:master branch from 4da2935 to 2b41800 Jun 21, 2019
@mxm

This comment has been minimized.

Copy link
Contributor

mxm commented Jun 21, 2019

Just did the squashing manually on your branch. Thanks @brucearctor!

@mxm mxm merged commit 553c560 into apache:master Jun 21, 2019
3 checks passed
3 checks passed
RAT ("Run RAT PreCommit") SUCCESS
Details
Website ("Run Website PreCommit") SUCCESS
Details
Website_Stage_GCS ("Run Website_Stage_GCS PreCommit") SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.