Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7598] Do not build Python tar file in run_integration_test.sh #8916

Merged
merged 1 commit into from Jun 24, 2019

Conversation

markflyhigh
Copy link
Contributor

Run script run_integration_test.sh is used by Gradle to execute Python test suite, which are running in parallel in Post/Pre-Commit. Building tar ball depends on shared temporary resources which can cause race condition, so we can't include it in this script. Since we have another Gradle task sdist to build the tar ball, only check SDK_LOCATION existence should be sufficient.

This can fix PostCommit flaky in https://issues.apache.org/jira/browse/BEAM-7598.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@markflyhigh markflyhigh requested a review from udim June 20, 2019 16:36
@markflyhigh
Copy link
Contributor Author

Run Python PostCommit

@markflyhigh
Copy link
Contributor Author

PTAL @udim

@udim
Copy link
Member

udim commented Jun 20, 2019

Run Python PostCommit

1 similar comment
@markflyhigh
Copy link
Contributor Author

Run Python PostCommit

@markflyhigh
Copy link
Contributor Author

PTAL @udim

@markflyhigh
Copy link
Contributor Author

+R: @tvalentyn

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Mark!

@markflyhigh
Copy link
Contributor Author

PTAL @tvalentyn

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @markflyhigh !

@markflyhigh
Copy link
Contributor Author

The failure job Portable_Python is caused by infra and not related to this change. Python Precommit has good coverage on this script. I'll go ahead and merge it.

@markflyhigh markflyhigh merged commit 5b91cb4 into apache:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants