Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7649] Match Python 3 warning message in __init__.py with the one in setup.py. #8956

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Jun 27, 2019

Beam has been offering Python 3 support for last 3 releases. Since then we made several improvements and established a solid test coverage. Aside from minor known issues, Beam is ready to be used on Python 3, therefore updating this warning message. Note that this change should have been included in #8867, that updates the warning message in setup.py, but was missed.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tvalentyn
Copy link
Contributor Author

R: @akedin

@tvalentyn
Copy link
Contributor Author

Run Portable_Python PreCommit

@tvalentyn tvalentyn changed the title [BEAM-1251] Match Python 3 warning message in __init__.py with the one in setup.py. [BEAM-7649] Match Python 3 warning message in __init__.py with the one in setup.py. Jun 27, 2019
Copy link
Contributor

@akedin akedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akedin akedin merged commit 063091e into apache:master Jun 27, 2019
@tvalentyn tvalentyn deleted the classifiers branch October 23, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants