Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7666] Throttle piping #8971

Merged
merged 3 commits into from Jul 15, 2019
Merged

[BEAM-7666] Throttle piping #8971

merged 3 commits into from Jul 15, 2019

Conversation

dustin12
Copy link
Contributor

@dustin12 dustin12 commented Jul 1, 2019

Adds a counter to tell dataflow if the worker is spending too much time garbage collecting so that we can avoid autoscaling to small worker numbers if memory pressure is too high.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@dustin12
Copy link
Contributor Author

dustin12 commented Jul 1, 2019

@pabloem - Hello, trying to merge some changes in we need for streaming dataflow autoscaling. The internal CL with LGTM and approval is here: https://critique.corp.google.com/#review/255257716 . Thanks!

@dustin12 dustin12 changed the title Throttle piping [BEAM-7666] Throttle piping Jul 8, 2019
@dustin12
Copy link
Contributor Author

@pabloem ping now that everyone is back from the long weekend :)

@dustin12
Copy link
Contributor Author

@angoenka Do you have committer status? First comment has the critique link with LGTM from other members of the streaming team.

Copy link
Contributor

@angoenka angoenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@angoenka angoenka merged commit 8001ad2 into apache:master Jul 15, 2019
@dustin12 dustin12 deleted the ThrottlePiping branch July 18, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants