New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-7726] Implement State Backed Iterables in Go SDK #9080
Conversation
R: @robertwb, @lukecwik [1] https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto#L582 |
Run Go PreCommit |
cc: @herohde In case you've got thoughts on the refactoring. Otherwise, I'm investigating the PreCommit failure. It looks like it's a Go Gradle thing WRT vendoring. It might be time to do away with it. |
cc: @ananvay |
R: @youngoli |
Run Go PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two small clarification questions but no actual issues, so LGTM (edit: once it passes Go Precommit of course).
Had a little trouble understanding the implementation of datasource_test.go, so hopefully there's no errors hidden in the implementation. But test coverage-wise it looks good.
Ah, thanks for catching that. The docs are wrong (java uses -1 as well [3], and otherwise there'd be ambiguity in encoding an empty list). #9099 |
Run Go PostCommit |
It seems that between Go Gradle, and the version of go we have it run (go 1.10) it looks like the Beam Go SDK is no longer compatible with go 1.10. |
Run Go PreCommit |
33d3fac
to
0d64dbc
Compare
Run Go PostCommit |
This PR does a few things towards adding State Backed Iterables
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.