[BEAM-7664] add more Python GBK Flink test cases #9106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkucharc
force-pushed
the
BEAM-7664-add-more-gbk-flink-test-cases
branch
3 times, most recently
from
573c27f
to
2d85bcf
Compare
|
run seed job |
|
Run Load Tests Python GBK Flink Batch |
lgajowy
requested changes
Jul 25, 2019
| ] | ||
| ]} | ||
|
|
||
| def testConfigurationWithSixteenWorkers = { datasetName -> [ |
There was a problem hiding this comment.
I think we should try keep the configurations together in one list if possible. Then do something like (pseudocode, just to sketch the idea):
setup5WorkerFlink()
def testsToRun = testConfigurations.findAll { it -> it.jobProperties.parallelism = 5 }
run (testsToRun)
scaleCluster(16 /* workers */);
def testsToRun = testConfigurations.findAll { it -> it.jobProperties.parallelism = 16 }
run(testsToRun)
In case we have some more sophisticated criteria, we have all the data in one place and construct the query however we want. :)
There was a problem hiding this comment.
Ok, I changed it so it's more flexible thanks to few closures :)
|
|
||
| loadTestsBuilder.loadTest(scope, testConfig.title, testConfig.runner, testConfig.sdk, testConfig.jobProperties, testConfig.itClass) | ||
| numberOfWorkers = 5 | ||
| infra.scaleCluster(scope, jenkinsJobName, numberOfWorkers) |
There was a problem hiding this comment.
This scaling sounds really cool. 😎
kkucharc
force-pushed
the
BEAM-7664-add-more-gbk-flink-test-cases
branch
2 times, most recently
from
5c3b76a
to
1ec3008
Compare
|
run seed job |
|
Run Load Tests Python GBK Flink Batch |
|
@lgajowy This is ready, I applied your suggestion. I also rebased with master (there were some conflicts) |
lgajowy
approved these changes
Aug 1, 2019
kkucharc
force-pushed
the
BEAM-7664-add-more-gbk-flink-test-cases
branch
from
8899f77
to
dace04f
Compare
|
Thank you @lgajowy I just reorganised it. |
|
Run seed job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.