Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-7747] Close the file handle owned by fastavro.write.Writer in _FastAvroSink.close(). #9111

Merged
merged 1 commit into from
Jul 24, 2019
Merged

[BEAM-7747] Close the file handle owned by fastavro.write.Writer in _FastAvroSink.close(). #9111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/python/apache_beam/io/avroio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,3 +629,4 @@ def write_record(self, writer, value):

def close(self, writer):
writer.flush()
writer.fo.close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just do a "super(_FastAvroSink, self).close()" since file handle is closed at FileBasedSink.

beam/sdks/python/apache_beam/io/filebasedsink.py

Line 144 in 0ac265b

def close(self, file_handle):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FileBasedSink.close(writer) calls writer.close():

beam/sdks/python/apache_beam/io/filebasedsink.py

Line 152 in ab80cc5

file_handle.close()

However FastAvro writer only has flush(), but does not have close(): https://github.com/fastavro/fastavro/blob/53ed64d95d4f82875d1238b1f76d4d87547e40e1/fastavro/_write_py.py#L336

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks.